summaryrefslogtreecommitdiff
path: root/builtin/for-each-ref.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2016-04-09 13:43:54 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-04-10 11:14:59 -0700
commit1cae428e2902b3f19a56625411f09cc239855fe7 (patch)
tree1bc5d010b78e12c137515770ec73892f4ffde2c3 /builtin/for-each-ref.c
parentgit_config_set_multivar_in_file: all non-zero returns are errors (diff)
downloadtgif-1cae428e2902b3f19a56625411f09cc239855fe7.tar.xz
git_config_set_multivar_in_file: handle "unset" errors
We pass off to the "_gently" form to do the real work, and just die() if it returned an error. However, our die message de-references "value", which may be NULL if the request was to unset a variable. Nobody using glibc noticed, because it simply prints "(null)", which is good enough for the test suite (and presumably very few people run across this in practice). But other libc implementations (like Solaris) may segfault. Let's not only fix that, but let's make the message more clear about what is going on in the "unset" case. Reported-by: "Tom G. Christensen" <tgc@jupiterrise.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/for-each-ref.c')
0 files changed, 0 insertions, 0 deletions