diff options
| author |  Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-08-23 14:30:16 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2021-08-30 17:06:18 -0700 |
| commit | 8722f9fb6b7705a3354e2d40d6dba0b86c1dab0d (patch) | |
| tree | a32fc013b1ec98b943a132a6dc205b3fbacdf6d3 /builtin/commit-graph.c | |
| parent | commit-graph: define common usage with a macro (diff) | |
| download | tgif-8722f9fb6b7705a3354e2d40d6dba0b86c1dab0d.tar.xz | |
commit-graph: remove redundant handling of -h
If we don't handle the -h option here like most parse_options() users
we'll fall through and it'll do the right thing for us.
I think this code added in 4ce58ee38d (commit-graph: create
git-commit-graph builtin, 2018-04-02) was always redundant,
parse_options() did this at the time, and the commit-graph code never
used PARSE_OPT_NO_INTERNAL_HELP.
We don't need a test for this, it's tested by the t0012-help.sh test
added in d691551192a (t0012: test "-h" with builtins, 2017-05-30).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit-graph.c')
| -rw-r--r-- | builtin/commit-graph.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c index 5af3cd7178..3cf18dc534 100644 --- a/builtin/commit-graph.c +++ b/builtin/commit-graph.c @@ -321,10 +321,6 @@ int cmd_commit_graph(int argc, const char **argv, const char *prefix) OPT_END(), }; - if (argc == 2 && !strcmp(argv[1], "-h")) - usage_with_options(builtin_commit_graph_usage, - builtin_commit_graph_options); - git_config(git_default_config, NULL); argc = parse_options(argc, argv, prefix, builtin_commit_graph_options, |