diff options
| author |  Phillip Wood <phillip.wood@dunelm.org.uk> | 2017-11-15 12:40:43 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-11-16 10:36:16 +0900 |
| commit | c5e3bc6ec46071397b40582157214d374d1b4fab (patch) | |
| tree | a698b2329a07becd0211adb62f8cb76066c9947c /builtin/column.c | |
| parent | branch: fix "copy" to never touch HEAD (diff) | |
| download | tgif-c5e3bc6ec46071397b40582157214d374d1b4fab.tar.xz | |
config: avoid "write_in_full(fd, buf, len) != len" pattern
As explained in commit 06f46f237 (avoid "write_in_full(fd, buf, len)
!= len" pattern, 2017–09–13) the return value of write_in_full() is
either -1 or the requested number of bytes. As such comparing the
return value to an unsigned value such as strbuf.len will fail to
catch errors. Change the code to use the preferred '< 0' check.
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/column.c')
0 files changed, 0 insertions, 0 deletions