diff options
author | Jeff King <peff@peff.net> | 2014-09-14 03:35:06 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-09-16 11:11:58 -0700 |
commit | f5e3c0b9d050ebdaf96d3910b01b01695e3ea1a2 (patch) | |
tree | 25ba70a24be840428e49b1ff9fcd53b69dba48ac /builtin/checkout-index.c | |
parent | Merge git://github.com/git-l10n/git-po (diff) | |
download | tgif-f5e3c0b9d050ebdaf96d3910b01b01695e3ea1a2.tar.xz |
credential-cache: close stderr in daemon process
If the stderr of "git credential-cache" is redirected to a
pipe, the reader on the other end of a pipe may be surprised
that the pipe remains open long after the process exits.
This happens because we may auto-spawn a daemon which is
long-lived, and which keeps stderr open.
We can solve this by redirecting the daemon's stderr to
/dev/null once we are ready to go into our event loop. We
would not want to do so before then, because we may want to
report errors about the setup (e.g., failure to establish
the listening socket).
This does mean that we will not report errors we encounter
for specific clients. That's acceptable, as such errors
should be rare (e.g., clients sending buggy requests).
However, we also provide an escape hatch: if you want to see
these later messages, you can provide the "--debug" option
to keep stderr open.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/checkout-index.c')
0 files changed, 0 insertions, 0 deletions