diff options
author | Ronnie Sahlberg <sahlberg@google.com> | 2014-09-11 08:42:57 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-10-15 10:47:26 -0700 |
commit | 2ebb49ca8ac34afb0ffe00e4bceac73e8c825ef1 (patch) | |
tree | 6d08ad37be2ac2cc2b2bedbc558a7e5a510defcc /builtin/check-ignore.c | |
parent | for-each-ref: skip and warn about broken ref names (diff) | |
download | tgif-2ebb49ca8ac34afb0ffe00e4bceac73e8c825ef1.tar.xz |
remote rm/prune: print a message when writing packed-refs fails
Until v2.1.0-rc0~22^2~11 (refs.c: add an err argument to
repack_without_refs, 2014-06-20), repack_without_refs forgot to
provide an error message when commit_packed_refs fails. Even today,
it only provides a message for callers that pass a non-NULL err
parameter. Internal callers in refs.c pass non-NULL err but
"git remote" does not.
That means that "git remote rm" and "git remote prune" can fail
without printing a message about why. Fix them by passing in a
non-NULL err parameter and printing the returned message.
This is the last caller to a ref handling function passing err ==
NULL. A later patch can drop support for err == NULL, avoiding such
problems in the future.
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/check-ignore.c')
0 files changed, 0 insertions, 0 deletions