diff options
| author |  Isabella Stephens <istephens@atlassian.com> | 2018-06-15 16:29:27 +1000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-06-15 10:29:13 -0700 |
| commit | 96cfa94e68cfbe9942e230ae18b35eaf1ca30f99 (patch) | |
| tree | a1e806e0b896c3f60c83cecb987c4e8425b6e6e6 /builtin/blame.c | |
| parent | Git 2.17.1 (diff) | |
| download | tgif-96cfa94e68cfbe9942e230ae18b35eaf1ca30f99.tar.xz | |
blame: prevent error if range ends past end of file
If the -L option is used to specify a line range in git blame, and the
end of the range is past the end of the file, git will fail with a fatal
error. This commit prevents such behavior - instead we display the blame
for existing lines within the specified range. Tests are amended
accordingly.
This commit also fixes two corner cases. Blaming -L n,-(n+1) now blames
the first n lines of a file rather than from n to the end of the file.
Blaming -L ,-n will be treated as -L 1,-n and blame the first line of
the file, rather than blaming the whole file.
Signed-off-by: Isabella Stephens <istephens@atlassian.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/blame.c')
| -rw-r--r-- | builtin/blame.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/blame.c b/builtin/blame.c index 9dcb367b90..e1359b1927 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -886,13 +886,13 @@ parse_done: nth_line_cb, &sb, lno, anchor, &bottom, &top, sb.path)) usage(blame_usage); - if (lno < top || ((lno || bottom) && lno < bottom)) + if ((!lno && (top || bottom)) || lno < bottom) die(Q_("file %s has only %lu line", "file %s has only %lu lines", lno), path, lno); if (bottom < 1) bottom = 1; - if (top < 1) + if (top < 1 || lno < top) top = lno; bottom--; range_set_append_unsafe(&ranges, bottom, top); |