diff options
| author |  Keith Cascio <keith@cs.ucla.edu> | 2009-02-16 18:59:00 -0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2009-03-04 00:56:51 -0800 |
| commit | e752f4bba24afe964eb42d6c2b8bf06cc77c9ce4 (patch) | |
| tree | df34d7093c4deb2db45569c964d54837fcf84dcc /builtin-rev-list.c | |
| parent | Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking (diff) | |
| download | tgif-e752f4bba24afe964eb42d6c2b8bf06cc77c9ce4.tar.xz | |
Fix neglect of diff_setup()/diff_setup_done() symmetry.
Code that calls diff_setup(), including via init_revisions(), should later call
diff_setup_done(), possibly via setup_revisions(). Failure to do so could cause
errors, especially in the future when we add responsibilities to
diff_setup_done(). This instance causes no known errors with the present code.
But it resulted in an error with an experimental patch.
Signed-off-by: Keith Cascio <keith@cs.ucla.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-rev-list.c')
0 files changed, 0 insertions, 0 deletions