summaryrefslogtreecommitdiff
path: root/builtin-log.c
diff options
context:
space:
mode:
authorLibravatar Eric W. Biederman <ebiederm@xmission.com>2006-06-12 13:31:38 -0600
committerLibravatar Junio C Hamano <junkio@cox.net>2006-06-17 18:51:53 -0700
commit6c4cca1c72f98c84a21a2d1916a8e86be57d26e6 (patch)
tree70d39f995b18d025f139c93fb2367a4eab465e83 /builtin-log.c
parentSome more memory leak avoidance (diff)
downloadtgif-6c4cca1c72f98c84a21a2d1916a8e86be57d26e6.tar.xz
Fix git-format-patch -s
When git-format-patch was converted to a builtin an appropriate call to setup_ident was missed and thus git-format-patch -s fails because it doesn't look up anything in the password file. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-log.c')
-rw-r--r--builtin-log.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/builtin-log.c b/builtin-log.c
index 6afa66ce02..9187fd337b 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -220,8 +220,11 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
}
else if (!strcmp(argv[i], "--signoff") ||
!strcmp(argv[i], "-s")) {
- const char *committer = git_committer_info(1);
- const char *endpos = strchr(committer, '>');
+ const char *committer;
+ const char *endpos;
+ setup_ident();
+ committer = git_committer_info(1);
+ endpos = strchr(committer, '>');
if (!endpos)
die("bogos committer info %s\n", committer);
add_signoff = xmalloc(endpos - committer + 2);