diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-03-21 23:36:20 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-03-22 12:22:26 -0700 |
commit | 2be927f3d1c64217ac5f4d3139ad73c1f59c173b (patch) | |
tree | dd3fdaea9af275dd066268541e8a6aa5e47ed62b /block-sha1 | |
parent | diff --no-index tests: add test for --exit-code (diff) | |
download | tgif-2be927f3d1c64217ac5f4d3139ad73c1f59c173b.tar.xz |
diff --no-index tests: test mode normalization
When "git diff --no-index X Y" is run the modes of the files being
differ are normalized by canon_mode() in fill_filespec().
I recently broke that behavior in a patch of mine[1] which would pass
all tests, or not, depending on the umask of the git.git checkout.
Let's test for this explicitly. Arguably this should not be the
behavior of "git diff --no-index". We aren't diffing our own objects
or the index, so it might be useful to show mode differences between
files.
On the other hand diff(1) does not do that, and it would be needlessly
distracting when e.g. diffing an extracted tar archive whose contents
is the same, but whose file modes are different.
1. https://lore.kernel.org/git/20210316155829.31242-2-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'block-sha1')
0 files changed, 0 insertions, 0 deletions