diff options
author | Pranit Bauva <pranit.bauva@gmail.com> | 2020-02-17 09:40:37 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-02-19 09:37:14 -0800 |
commit | 45b6370812cb9bc50212d50f071c8ae5dd851698 (patch) | |
tree | 42c80045e6a4bd009b75d51d219fc4e4010d67de /bisect.h | |
parent | bisect: libify `check_merge_bases` and its dependents (diff) | |
download | tgif-45b6370812cb9bc50212d50f071c8ae5dd851698.tar.xz |
bisect: libify `check_good_are_ancestors_of_bad` and its dependents
Since we want to get rid of git-bisect.sh, it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit(<positive-value>)` to
`return <negative-value>`. Follow POSIX conventions to return
<negative-value> to indicate error.
Code that turns BISECT_INTERNAL_SUCCESS_MERGE_BASE (-11)
to BISECT_OK (0) from `check_good_are_ancestors_of_bad()` has been moved to
`cmd_bisect__helper()`.
Update all callers to handle the error returns.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'bisect.h')
0 files changed, 0 insertions, 0 deletions