summaryrefslogtreecommitdiff
path: root/archive.h
diff options
context:
space:
mode:
authorLibravatar Johannes Sixt <j6t@kdbg.org>2016-08-09 16:16:33 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-08-09 10:19:24 -0700
commitdc29ddebb969af489cdfd5dbbf424710973ef62f (patch)
tree09dc56ce63f211fd890fa5087c1bd54de69c0927 /archive.h
parentGit 2.4.11 (diff)
downloadtgif-dc29ddebb969af489cdfd5dbbf424710973ef62f.tar.xz
config.c: avoid duplicated global static variables
Repeating the definition of a static variable seems to be valid in C. Nevertheless, it is bad style because it can cause confusion, definitely when it becomes necessary to change the type. d64ec16 (git config: reorganize to use parseopt, 2009-02-21) added two static variables near the top of the file config.c without removing the definitions of the two variables that occurs later in the file. The two variables were needed earlier in the file in the newly introduced parseopt structure. These references were removed later in d0e08d6 (config: fix parsing of "git config --get-color some.key -1", 2014-11-20). Remove the redundant, younger, definitions near the top of the file and keep the original definitions that occur later. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'archive.h')
0 files changed, 0 insertions, 0 deletions