diff options
author | Jonathan Nieder <jrnieder@gmail.com> | 2010-09-06 20:52:27 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2010-09-09 16:01:10 -0700 |
commit | 8fe5aeddcbeb194ea0f6e23e1f7b4ac38809921b (patch) | |
tree | 2eb74458429acd2eba60e4a86529c66f87ddeec0 /advice.c | |
parent | t2105 (gitfile): add missing && (diff) | |
download | tgif-8fe5aeddcbeb194ea0f6e23e1f7b4ac38809921b.tar.xz |
t1302 (core.repositoryversion): style tweaks
This test is from 2007, which is late enough for the style to be
recognizably modern but still a while ago. Freshen it up to
follow new best practices:
- guard setup commands with test_expect_setup, so errors at
that stage can be caught;
- use <<\EOF in preference to <<EOF, to save reviewers the
trouble of looking for variable interpolations;
- use test_cmp instead of test "$foo" = "$bar", for better
output with -v on failure;
- indent commands in subshells and let them span multiple lines;
- combine the two "gitdir required mode" tests that do not make
as much sense alone.
Cc: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'advice.c')
0 files changed, 0 insertions, 0 deletions