diff options
| author |  Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2019-05-29 16:11:15 +0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-05-29 11:04:32 -0700 |
| commit | 8ef05193bcdda6a28cd41fa3ecd8f356061d49e0 (patch) | |
| tree | d320df22f655cd124361fc5b93f564437dcb65de /advice.c | |
| parent | diff-parseopt: correct variable types that are used by parseopt (diff) | |
| download | tgif-8ef05193bcdda6a28cd41fa3ecd8f356061d49e0.tar.xz | |
diff-parseopt: restore -U (no argument) behavior
Before d473e2e0e8 (diff.c: convert -U|--unified, 2019-01-27), -U and
--unified are implemented with a custom parser opt_arg() in diff.c. I
didn't check this code carefully and not realize that it's the
equivalent of PARSE_OPT_NONEG | PARSE_OPT_OPTARG.
In other words, if -U is specified without any argument, the option
should be accepted, and the default value should be used. Without
PARSE_OPT_OPTARG, parse_options() will reject this case and cause a
regression.
Reported-by: Bryan Turner <bturner@atlassian.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'advice.c')
0 files changed, 0 insertions, 0 deletions