diff options
author | Taylor Blau <me@ttaylorr.com> | 2020-05-13 15:59:33 -0600 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-05-13 15:20:45 -0700 |
commit | d335ce8f24e335ffda911f01a9569f7132e64cdb (patch) | |
tree | 41c0f6ff29abd525ae871d5b024a1591b521e1b8 /add-patch.c | |
parent | commit-graph.c: extract 'refs_cb_data' (diff) | |
download | tgif-d335ce8f24e335ffda911f01a9569f7132e64cdb.tar.xz |
commit-graph.c: show progress of finding reachable commits
When 'git commit-graph write --reachable' is invoked, the commit-graph
machinery calls 'for_each_ref()' to discover the set of reachable
commits.
Right now the 'add_ref_to_set' callback is not doing anything other than
adding an OID to the set of known-reachable OIDs. In a subsequent
commit, 'add_ref_to_set' will presumptively peel references. This
operation should be fast for repositories with an up-to-date
'$GIT_DIR/packed-refs', but may be slow in the general case.
So that it doesn't appear that 'git commit-graph write' is idling with
'--reachable' in the slow case, add a progress meter to provide some
output in the meantime.
In general, we don't expect a progress meter to appear at all, since
peeling references with a 'packed-refs' file is quick. If it's slow and
we do show a progress meter, the subsequent 'fill_oids_from_commits()'
will be fast, since all of the calls to
'lookup_commit_reference_gently()' will be no-ops.
Both progress meters are delayed, so it is unlikely that more than one
will appear. In either case, this intermediate state will go away in a
handful of patches, at which point there will be at most one progress
meter.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'add-patch.c')
0 files changed, 0 insertions, 0 deletions