summaryrefslogtreecommitdiff
path: root/Makefile
diff options
context:
space:
mode:
authorLibravatar Jonathan Nieder <jrnieder@gmail.com>2014-05-23 11:44:05 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-05-23 12:17:38 -0700
commit561b46c5c8a9d204974e6edd4f58a5fca343d6d3 (patch)
treefc87d6837ad6cc47e7ae6c24868aec05beab76ea /Makefile
parentGit 1.8.5.5 (diff)
downloadtgif-561b46c5c8a9d204974e6edd4f58a5fca343d6d3.tar.xz
test-lint: find unportable sed, echo, test, and export usage after &&
Instead of anchoring these checks with "^\s*", just check that the usage is preceded by a word boundary. So now we can catch test $cond && export foo=bar just like we already catch test $cond && export foo=bar As a side effect, this will detect usage of "sed -i", "echo -n", "test a == b", and "export a=b" in comments. That is not ideal but it's potentially useful because people sometimes copy code from comments so it can be good to also avoid nonportable patterns there. To avoid false positives, keep the checks for 'declare' and 'which' anchored. Those are frequently used words in normal English-language comments. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions