diff options
author | Jeff King <peff@peff.net> | 2021-09-15 14:36:38 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-09-15 12:25:19 -0700 |
commit | ccf094788c50c597972ee1fd9c2b554cadc0f14c (patch) | |
tree | 53e1be40071746184f9578510771a3f53e9ffd24 /Documentation | |
parent | serve: reject commands used as capabilities (diff) | |
download | tgif-ccf094788c50c597972ee1fd9c2b554cadc0f14c.tar.xz |
ls-refs: reject unknown arguments
The v2 ls-refs command may receive extra arguments from the client, one
per pkt-line. The spec is pretty clear that the arguments must come from
a specified set, but we silently ignore any unknown entries. For a
well-behaved client this doesn't matter, but it makes testing and
debugging more confusing. Let's tighten this up to match the spec.
In theory this liberal behavior _could_ be useful for extending the
protocol. But:
- every other part of the protocol requires that the server first
indicate that it supports the argument; this includes the fetch and
object-info commands, plus the "unborn" capability added to ls-refs
itself
- it's not a very good extension mechanism anyway; without the server
advertising support, clients would have no idea if the argument was
silently ignored, or accepted and simply had no effect
So we're not really losing anything by tightening this.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions