diff options
author | Martin Ågren <martin.agren@gmail.com> | 2020-11-21 19:31:07 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-11-21 14:50:29 -0800 |
commit | 1d3878799f8260968ea9f6a75a92c4daca1da133 (patch) | |
tree | b39016c5b5c1baddfc98117bc402b2bbd11a258c /Documentation | |
parent | Sixth batch (diff) | |
download | tgif-1d3878799f8260968ea9f6a75a92c4daca1da133.tar.xz |
grep: don't set up a "default" repo for grep
`init_grep_defaults()` fills a `static struct grep_opt grep_defaults`.
This struct is then used by `grep_init()` as a blueprint for other such
structs. Notably, `grep_init()` takes a `struct repo *` and assigns it
into the target struct.
As a result, it is unnecessary for us to take a `struct repo *` in
`init_grep_defaults()` as well. We assign it into the default struct and
never look at it again. And in light of how we return early if we have
already set up the default struct, it's not just unnecessary, but is
also a bit confusing: If we are called twice and with different repos,
is it a bug or a feature that we ignore the second repo?
Drop the repo parameter for `init_grep_defaults()`.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation')
-rw-r--r-- | Documentation/MyFirstObjectWalk.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt index c3f2d1a831..85434d1938 100644 --- a/Documentation/MyFirstObjectWalk.txt +++ b/Documentation/MyFirstObjectWalk.txt @@ -394,7 +394,7 @@ First some setup. Add `init_grep_defaults()` to `init_walken_defaults()` and add ---- static void init_walken_defaults(void) { - init_grep_defaults(the_repository); + init_grep_defaults(); } ... |