summaryrefslogtreecommitdiff
path: root/Documentation/urls-remotes.txt
diff options
context:
space:
mode:
authorLibravatar Jakub Narebski <jnareb@gmail.com>2008-02-14 09:22:30 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2008-03-12 09:43:08 -0700
commit7863c612f402268b5978683f44adad3a7a867613 (patch)
tree401ced768f29e3d290af4f2d10e68fe13417f601 /Documentation/urls-remotes.txt
parentgit-svn: fix find-rev error message when missing arg (diff)
downloadtgif-7863c612f402268b5978683f44adad3a7a867613.tar.xz
gitweb: Fix bug in href(..., -replay=>1) when using 'pathinfo' form
URLs generated by href(..., -replay=>1) (which includes 'next page' links and alternate view links) didn't set project info correctly when current page URL is in pathinfo form. This resulted in broken links such like: http://www.example.com/w/ARRAY(0x85a5318)?a=shortlog;pg=1 if the 'pathinfo' feature was used, or http://www.example.com/w/?a=shortlog;pg=1 if it wasn't, instead of correct: http://www.example.com/w/project.git?a=shortlog;pg=1 This was caused by the fact that href() always replays params in the arrayref form, were they multivalued or singlevalued, and the code dealing with 'pathinfo' feature couldn't deal with $params{'project'} being arrayref. Setting $params{'project'} is moved before replaying params; this ensures that 'project' parameter is processed correctly. Noticed-by: Peter Oberndorfer <kumbayo84@arcor.de> Noticed-by: Wincent Colaiuta <win@wincent.com> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/urls-remotes.txt')
0 files changed, 0 insertions, 0 deletions