summaryrefslogtreecommitdiff
path: root/Documentation/technical
diff options
context:
space:
mode:
authorLibravatar René Scharfe <l.s.r@web.de>2015-05-19 01:24:09 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-05-19 09:31:09 -0700
commit599dc766e89fe4f964c197f8d109dfc2e3c890ba (patch)
treef09a09a6350f8ac6ad89df4c9cdbbca32dd4c2ee /Documentation/technical
parentGit 2.3.5 (diff)
downloadtgif-599dc766e89fe4f964c197f8d109dfc2e3c890ba.tar.xz
pack-bitmaps: plug memory leak, fix allocation size for recent_bitmaps
Use an automatic variable for recent_bitmaps, an array of pointers. This way we don't allocate too much and don't have to free the memory at the end. The old code over-allocated because it reserved enough memory to store all of the structs it is only pointing to and never freed it. 160 64-bit pointers take up 1280 bytes, which is not too much to be placed on the stack. MAX_XOR_OFFSET is turned into a preprocessor constant to make it constant enough for use in an non-variable array declaration. Noticed-by: Stefan Beller <stefanbeller@gmail.com> Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/technical')
0 files changed, 0 insertions, 0 deletions