summaryrefslogtreecommitdiff
path: root/Documentation/technical/pack-format.txt
diff options
context:
space:
mode:
authorLibravatar Derrick Stolee <dstolee@microsoft.com>2018-09-21 08:05:27 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-09-21 11:36:29 -0700
commit4067a64672f9db8ca38d5a2682a7cdba7938c18b (patch)
treee688a5d2c6e5ca5c7036fc193ac4f24e2106e1ab /Documentation/technical/pack-format.txt
parentcommit-reach: properly peel tags (diff)
downloadtgif-4067a64672f9db8ca38d5a2682a7cdba7938c18b.tar.xz
commit-reach: fix memory and flag leaks
The can_all_from_reach_with_flag() method uses 'assign_flag' as a value we can use to mark objects temporarily during our commit walk. The intent is that these flags are removed from all objects before returning. However, this is not the case. The 'from' array could also contain objects that are not commits, and we mark those objects with 'assign_flag'. Add a loop to the 'cleanup' section that removes these markers. Also, we forgot to free() the memory for 'list', so add that to the 'cleanup' section. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/technical/pack-format.txt')
0 files changed, 0 insertions, 0 deletions