diff options
author | Jonathan Tan <jonathantanmy@google.com> | 2018-03-28 15:35:27 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-03-29 09:44:50 -0700 |
commit | 6856077ab063f16b4ccacff971c3ebb185935465 (patch) | |
tree | 0830c03cb7ce17dc2f4cd1d6f424a0364d022c4c /Documentation/technical/api-submodule-config.txt | |
parent | submodule.h: drop declaration of connect_work_tree_and_git_dir (diff) | |
download | tgif-6856077ab063f16b4ccacff971c3ebb185935465.tar.xz |
grep: remove "repo" arg from non-supporting funcs
As part of commit f9ee2fcdfa ("grep: recurse in-process using 'struct
repository'", 2017-08-02), many functions in builtin/grep.c were
converted to also take "struct repository *" arguments. Among them were
grep_object() and grep_objects().
However, at least grep_objects() was converted incompletely - it calls
gitmodules_config_oid(), which references the_repository.
But it turns out that the conversion was extraneous anyway - there has
been no user-visible effect - because grep_objects() is never invoked
except with the_repository. This is because grepping through objects
cannot be done recursively into submodules.
Revert the changes to grep_objects() and grep_object() (which conversion
is also extraneous) to show that both these functions do not support
repositories other than the_repository.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/technical/api-submodule-config.txt')
0 files changed, 0 insertions, 0 deletions