diff options
| author |  Jeff King <peff@peff.net> | 2014-04-19 15:17:06 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-04-21 10:29:50 -0700 |
| commit | 82fbf269b9994d172719b2d456db5ef8453b323d (patch) | |
| tree | 3cad5b6db3b1884b1de56661d8ef447d80ec1640 /Documentation/technical/api-strbuf.txt | |
| parent | Git 1.9.2 (diff) | |
| download | tgif-82fbf269b9994d172719b2d456db5ef8453b323d.tar.xz | |
run_external_diff: use an argv_array for the command line
We currently generate the command-line for the external
command using a fixed-length array of size 10. But if there
is a rename, we actually need 11 elements (10 items, plus a
NULL), and end up writing a random NULL onto the stack.
Rather than bump the limit, let's just use an argv_array, which
makes this sort of error impossible.
Noticed-by: Max L <infthi.inbox@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/technical/api-strbuf.txt')
0 files changed, 0 insertions, 0 deletions