summaryrefslogtreecommitdiff
path: root/Documentation/technical/api-setup.txt
diff options
context:
space:
mode:
authorLibravatar Jens Lehmann <Jens.Lehmann@web.de>2014-05-17 21:49:05 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-05-19 10:12:45 -0700
commitb3f0c5c04ed24d04a3403abf517bec439ebb40e2 (patch)
tree1ddf2ec4b34a36a7762a12e6dba869313d04ce99 /Documentation/technical/api-setup.txt
parentgit-gui 0.19 (diff)
downloadtgif-b3f0c5c04ed24d04a3403abf517bec439ebb40e2.tar.xz
git-gui: tolerate major version changes when comparing the git version
Since git 2.0.0 starting git gui in a submodule using a gitfile fails with the following error: No working directory ../../../<path> couldn't change working directory to "../../../<path>": no such file or directory This is because "git rev-parse --show-toplevel" is only run when git gui sees a git version of at least 1.7.0 (which is the version in which the --show-toplevel option was introduced). But "package vsatisfies" returns false when the major version changes, which is not what we want here. Fix that for both places where the git version is checked using vsatisfies by appending a '-' to the version number. This tells vsatisfies that a change of the major version is not considered to be a problem, as long as the new major version is larger. This is done for both the place that caused the reported bug and another spot where the git version is tested for another feature. Reported-by: Chris Packham <judge.packham@gmail.com> Reported-by: Yann Dirson <ydirson@free.fr> Helped-by: Pat Thoyts <patthoyts@users.sourceforge.net> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Tested-by: Chris Packham <judge.packham@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/technical/api-setup.txt')
0 files changed, 0 insertions, 0 deletions