summaryrefslogtreecommitdiff
path: root/Documentation/install-doc-quick.sh
diff options
context:
space:
mode:
authorLibravatar Glen Choo <chooglen@google.com>2022-03-07 16:14:33 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2022-03-16 16:08:59 -0700
commit5fff35d880df2bb4cfce032c54a95abadce3f881 (patch)
tree5b031c27857f5fb0468a7d05e6f6546aba56de1b /Documentation/install-doc-quick.sh
parentfetch: fetch unpopulated, changed submodules (diff)
downloadtgif-5fff35d880df2bb4cfce032c54a95abadce3f881.tar.xz
submodule: fix latent check_has_commit() bug
When check_has_commit() is called on a missing submodule, initialization of the struct repository fails, but it attempts to clear the struct anyway (which is a fatal error). This bug is masked by its only caller, submodule_has_commits(), first calling add_submodule_odb(). The latter fails if the submodule does not exist, making submodule_has_commits() exit early and not invoke check_has_commit(). Fix this bug, and because calling add_submodule_odb() is no longer necessary as of 13a2f620b2 (submodule: pass repo to check_has_commit(), 2021-10-08), remove that call too. This is the last caller of add_submodule_odb(), so remove that function. (Submodule ODBs are still added as alternates via add_submodule_odb_by_path().) Signed-off-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/install-doc-quick.sh')
0 files changed, 0 insertions, 0 deletions