diff options
| author |  Jonathan Nieder <jrnieder@gmail.com> | 2018-04-23 16:25:35 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-04-24 10:59:29 +0900 |
| commit | 64f982b8a791a8e9e612a103d05e5f01a08fce0f (patch) | |
| tree | ffaddd71596060bcabbf65a4d9ad966f53e37de2 /Documentation/howto/new-command.txt | |
| parent | Makefile: remove unused @@PERLLIBDIR@@ substitution variable (diff) | |
| download | tgif-64f982b8a791a8e9e612a103d05e5f01a08fce0f.tar.xz | |
Makefile: quote $INSTLIBDIR when passing it to sed
f6a0ad4b (Makefile: generate Perl header from template file,
2018-04-10) moved code for generating the 'use lib' lines at the top
of perl scripts from the $(SCRIPT_PERL_GEN) rule to a separate
GIT-PERL-HEADER rule.
This rule first populates INSTLIBDIR and then substitutes it into the
GIT-PERL-HEADER using sed:
INSTLIBDIR=... something ...
sed -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' $< > $@
Because $INSTLIBDIR is not surrounded by double quotes, the shell
splits it at each space, causing errors if INSTLIBDIR contains an $IFS
character:
sed: 1: "s=@@INSTLIBDIR@@=/usr/l ...": unescaped newline inside substitute pattern
Add back the missing double-quotes to make it work again.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/howto/new-command.txt')
0 files changed, 0 insertions, 0 deletions