summaryrefslogtreecommitdiff
path: root/Documentation/gitrepository-layout.txt
diff options
context:
space:
mode:
authorLibravatar Johannes Sixt <j6t@kdbg.org>2013-04-04 20:41:43 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2013-04-04 12:27:28 -0700
commitb9e31f59478eeae3e4230308f6fc06713c6fc547 (patch)
tree8efa207ccba7125535840a5dc6a90c601c8701dc /Documentation/gitrepository-layout.txt
parentrerere forget: grok files containing NUL (diff)
downloadtgif-b9e31f59478eeae3e4230308f6fc06713c6fc547.tar.xz
rerere forget: do not segfault if not all stages are present
The loop that fills in the buffers that are later passed to the merge driver exits early when not all stages of a path are present in the index. But since the buffer pointers are not initialized in advance, the subsequent accesses are undefined. Initialize buffer pointers in advance to avoid undefined behavior later. That is not sufficient, though, to get correct operation of handle_cache(). The function replays a conflicted merge to extract the part inside the conflict markers. As written, the loop exits early when a stage is missing. Consequently, the buffers for later stages that would be present in the index are not filled in and the merge is replayed with incomplete data. Fix it by investigating all stages of the given path. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/gitrepository-layout.txt')
0 files changed, 0 insertions, 0 deletions