diff options
author | Jeff King <peff@peff.net> | 2014-08-23 01:32:37 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-08-25 12:20:57 -0700 |
commit | c252785982c268e5c969900c677322744d09f52e (patch) | |
tree | 23f0fdc47e95e924827fc3039351f09a482f1eca /Documentation/gitcore-tutorial.txt | |
parent | fast-import: clean up pack_data pointer in end_packfile (diff) | |
download | tgif-c252785982c268e5c969900c677322744d09f52e.tar.xz |
fast-import: fix buffer overflow in dump_tags
When creating a new annotated tag, we sprintf the refname
into a static-sized buffer. If we have an absurdly long
tagname, like:
git init repo &&
cd repo &&
git commit --allow-empty -m foo &&
git tag -m message mytag &&
git fast-export mytag |
perl -lpe '/^tag/ and s/mytag/"a" x 8192/e' |
git fast-import <input
we'll overflow the buffer. We can fix it by using a strbuf.
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/gitcore-tutorial.txt')
0 files changed, 0 insertions, 0 deletions