summaryrefslogtreecommitdiff
path: root/Documentation/git-verify-tag.txt
diff options
context:
space:
mode:
authorLibravatar Jonathan Tan <jonathantanmy@google.com>2019-01-17 15:33:05 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-01-18 12:48:41 -0800
commite2f41a0a5aaa0116c9f1463fd779ce832eb773cc (patch)
tree68ff94301aa8b783046eb25a867c8b1df2b9e147 /Documentation/git-verify-tag.txt
parentSecond batch after 2.20 (diff)
downloadtgif-e2f41a0a5aaa0116c9f1463fd779ce832eb773cc.tar.xz
ls-refs: filter refs using namespace-stripped name
If a user fetches refs/heads/master from a repo with namespace "ns", the remote is expected to (1) not send the real refs/heads/master, and (2) send refs/namespaces/ns/refs/heads/master with the name refs/heads/master. (1) indeed happens now, but not (2) - Git only sends refs that have the user-given prefix, but it checks them against the full name of the ref (the one starting with refs/namespaces), and not the namespace-stripped one. This is demonstrated by the patch in the test. Currently, it results in "fatal: couldn't find remote ref refs/heads/master" despite both unnamespaced and namespaced master being present. With the code change, it produces the expected result. Check the ref prefixes against the namespace-stripped name. This bug was discovered through applying patches [1] that override protocol.version to 2 in repositories when running tests, allowing us to notice differences in behavior across different protocol versions. [1] https://public-inbox.org/git/cover.1547677183.git.jonathantanmy@google.com/ Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/git-verify-tag.txt')
0 files changed, 0 insertions, 0 deletions