diff options
author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2014-11-02 07:24:37 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-11-03 11:00:28 -0800 |
commit | fa137f67a40bbcb3f583920586fdd34ce98ddeaf (patch) | |
tree | 9f82bc0f053b03141bd2e53acf2a8d98517d325b /Documentation/git-stripspace.txt | |
parent | Git 2.2.0-rc0 (diff) | |
download | tgif-fa137f67a40bbcb3f583920586fdd34ce98ddeaf.tar.xz |
lockfile.c: store absolute path
Locked paths can be saved in a linked list so that if something wrong
happens, *.lock are removed. For relative paths, this works fine if we
keep cwd the same, which is true 99% of time except:
- update-index and read-tree hold the lock on $GIT_DIR/index really
early, then later on may call setup_work_tree() to move cwd.
- Suppose a lock is being held (e.g. by "git add") then somewhere
down the line, somebody calls real_path (e.g. "link_alt_odb_entry"),
which temporarily moves cwd away and back.
During that time when cwd is moved (either permanently or temporarily)
and we decide to die(), attempts to remove relative *.lock will fail,
and the next operation will complain that some files are still locked.
Avoid this case by turning relative paths to absolute before storing
the path in "filename" field.
Reported-by: Yue Lin Ho <yuelinho777@gmail.com>
Helped-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Helped-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Adapted-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/git-stripspace.txt')
0 files changed, 0 insertions, 0 deletions