diff options
author | Jeff King <peff@peff.net> | 2018-05-02 15:44:51 -0400 |
---|---|---|
committer | Jeff King <peff@peff.net> | 2018-05-21 23:55:12 -0400 |
commit | 7ac4f3a007e2567f9d2492806186aa063f9a08d6 (patch) | |
tree | 940b2dfa953d71d3838b89cdae8f9ab193fea6ea /Documentation/git-shortlog.txt | |
parent | fsck: simplify ".git" check (diff) | |
download | tgif-7ac4f3a007e2567f9d2492806186aa063f9a08d6.tar.xz |
fsck: actually fsck blob data
Because fscking a blob has always been a noop, we didn't
bother passing around the blob data. In preparation for
content-level checks, let's fix up a few things:
1. The fsck_object() function just returns success for any
blob. Let's a noop fsck_blob(), which we can fill in
with actual logic later.
2. The fsck_loose() function in builtin/fsck.c
just threw away blob content after loading it. Let's
hold onto it until after we've called fsck_object().
The easiest way to do this is to just drop the
parse_loose_object() helper entirely. Incidentally,
this also fixes a memory leak: if we successfully
loaded the object data but did not parse it, we would
have left the function without freeing it.
3. When fsck_loose() loads the object data, it
does so with a custom read_loose_object() helper. This
function streams any blobs, regardless of size, under
the assumption that we're only checking the sha1.
Instead, let's actually load blobs smaller than
big_file_threshold, as the normal object-reading
code-paths would do. This lets us fsck small files, and
a NULL return is an indication that the blob was so big
that it needed to be streamed, and we can pass that
information along to fsck_blob().
Signed-off-by: Jeff King <peff@peff.net>
Diffstat (limited to 'Documentation/git-shortlog.txt')
0 files changed, 0 insertions, 0 deletions