diff options
author | Junio C Hamano <gitster@pobox.com> | 2009-01-26 00:08:24 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2009-01-27 00:48:00 -0800 |
commit | b67b9612e1a90ae093445abeaeff930e9f4cf936 (patch) | |
tree | c8ad5731216e4196f33ccb4ce2ef5085264146a8 /Documentation/git-mailinfo.txt | |
parent | Fix Documentation for git-describe (diff) | |
download | tgif-b67b9612e1a90ae093445abeaeff930e9f4cf936.tar.xz |
diff.c: output correct index lines for a split diff
A patch that changes the filetype (e.g. regular file to symlink) of a path
must be split into a deletion event followed by a creation event, which
means that we need to have two independent metainfo lines for each.
However, the code reused the single set of metainfo lines.
As the blob object names recorded on the index lines are usually not used
nor validated on the receiving end, this is not an issue with normal use
of the resulting patch. However, when accepting a binary patch to delete
a blob, git-apply verified that the postimage blob object name on the
index line is 0{40}, hence a patch that deletes a regular file blob that
records binary contents to create a blob with different filetype (e.g. a
symbolic link) failed to apply. "git am -3" also uses the blob object
names recorded on the index line, so it would also misbehave when
synthesizing a preimage tree.
This moves the code to generate metainfo lines around, so that two
independent sets of metainfo lines are used for the split halves.
Additional tests by Jeff King.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/git-mailinfo.txt')
0 files changed, 0 insertions, 0 deletions