diff options
| author |  Luke Diamand <luke@diamand.org> | 2020-01-29 11:12:45 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-01-30 12:20:58 -0800 |
| commit | 6026aff5bbe7389fa276188237b58afbef1b07ff (patch) | |
| tree | 14d8791638c3104dea31569079a10e6d0143c0bc /Documentation/git-format-patch.txt | |
| parent | git-p4: create helper function importRevisions() (diff) | |
| download | tgif-6026aff5bbe7389fa276188237b58afbef1b07ff.tar.xz | |
git-p4: cleanup better on error exit
After an error, git-p4 calls die(). This just exits, and leaves child
processes still running.
Instead of calling die(), raise an exception and catch it where the
child process(es) (git-fastimport) are created.
This was analyzed in detail here:
https://public-inbox.org/git/20190227094926.GE19739@szeder.dev/
This change does not address the particular issue of p4CmdList()
invoking a subchild and not waiting for it on error.
Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/git-format-patch.txt')
0 files changed, 0 insertions, 0 deletions