diff options
| author |  Carlo Marcelo Arenas Belón <carenas@gmail.com> | 2019-05-14 14:11:17 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-05-15 11:03:08 +0900 |
| commit | 9dde06de130463c20f8b603ed3a3ffe10347f2f1 (patch) | |
| tree | ce28534f3755ace4bb2975f1652d0bc6a62bcf50 /Documentation/diff-options.txt | |
| parent | mingw: allow building with an MSYS2 runtime v3.x (diff) | |
| download | tgif-9dde06de130463c20f8b603ed3a3ffe10347f2f1.tar.xz | |
http-push: prevent format overflow warning with gcc >= 9
In function 'finish_request',
inlined from 'process_response' at http-push.c:248:2:
http-push.c:587:4: warning: '%s' directive argument is null [-Wformat-overflow=]
587 | fprintf(stderr, "Unable to get pack file %s\n%s",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
588 | request->url, curl_errorstr);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
request->url is needed for the error message if there was a failure
during fetch but was being cleared unnecessarily earlier.
note that the leak is prevented by calling release_request unconditionally
at the end.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Suggested-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/diff-options.txt')
0 files changed, 0 insertions, 0 deletions