diff options
| author |  Thomas Rast <trast@inf.ethz.ch> | 2013-06-21 13:38:00 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2013-06-21 08:36:07 -0700 |
| commit | 212eb96a96e256933a76e48d85fa4f500bed0dee (patch) | |
| tree | 114f51785e5003bb54b424f0bf5eabd574b53cc5 /Documentation/diff-generate-patch.txt | |
| parent | Git 1.7.11 (diff) | |
| download | tgif-212eb96a96e256933a76e48d85fa4f500bed0dee.tar.xz | |
apply: carefully strdup a possibly-NULL name
2901bbe (apply: free patch->{def,old,new}_name fields, 2012-03-21)
cleaned up the memory management of filenames in the patches, but
forgot that find_name_traditional() can return NULL as a way of saying
"I couldn't find a name".
That NULL unfortunately gets passed into xstrdup() next, resulting in
a segfault. Use null_strdup() so as to safely propagate the null,
which will let us emit the correct error message.
Reported-by: DevHC on #git
Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/diff-generate-patch.txt')
0 files changed, 0 insertions, 0 deletions