summaryrefslogtreecommitdiff
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2020-11-02 13:17:47 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-11-02 13:17:47 -0800
commitea9611573ba441359b43c3ddf67fa8ecbefd9166 (patch)
tree3a623fedb7470fbf326e94bc4b5e7947e2f11ead /Documentation/SubmittingPatches
parentMerge branch 'es/tutorial-mention-asciidoc-early' (diff)
parentSubmittingPatches: clarify the purpose of the final resend (diff)
downloadtgif-ea9611573ba441359b43c3ddf67fa8ecbefd9166.tar.xz
Merge branch 'jc/doc-final-resend'
Update developer doc. * jc/doc-final-resend: SubmittingPatches: clarify the purpose of the final resend
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches8
1 files changed, 5 insertions, 3 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 3bf2147787..d12094bac5 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -290,12 +290,14 @@ identify them), to solicit comments and reviews.
:git-ml: footnote:[The mailing list: git@vger.kernel.org]
After the list reached a consensus that it is a good idea to apply the
-patch, re-send it with "To:" set to the maintainer{current-maintainer} and "cc:" the
-list{git-ml} for inclusion.
+patch, re-send it with "To:" set to the maintainer{current-maintainer}
+and "cc:" the list{git-ml} for inclusion. This is especially relevant
+when the maintainer did not heavily participate in the discussion and
+instead left the review to trusted others.
Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and
`Tested-by:` lines as necessary to credit people who helped your
-patch.
+patch, and "cc:" them when sending such a final version for inclusion.
[[sign-off]]
=== Certify your work by adding your `Signed-off-by` trailer