diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2020-10-09 11:56:52 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-10-26 22:33:48 -0700 |
| commit | d95b192efda2c437d7a44f15db6d9b9f6ac1b5f9 (patch) | |
| tree | 4d41d9bc3fe5b75bb038e03548f3be58b28035b1 /Documentation/SubmittingPatches | |
| parent | other small fixes for 2.29.2 (diff) | |
| download | tgif-d95b192efda2c437d7a44f15db6d9b9f6ac1b5f9.tar.xz | |
SubmittingPatches: clarify the purpose of the final resend
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/SubmittingPatches')
| -rw-r--r-- | Documentation/SubmittingPatches | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 291b61e262..87089654ae 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -290,12 +290,14 @@ identify them), to solicit comments and reviews. :git-ml: footnote:[The mailing list: git@vger.kernel.org] After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} and "cc:" the -list{git-ml} for inclusion. +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your -patch. +patch, and "cc:" them when sending such a final version for inclusion. [[sign-off]] === Certify your work by adding your "Signed-off-by: " line |