summaryrefslogtreecommitdiff
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2010-10-06 13:49:45 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2010-10-06 13:49:45 -0700
commitc752e7f3e8d96a9673ad248addc9418164bd3ce6 (patch)
tree812bbca3530914a49161074d1aa1f4f051737c09 /Documentation/SubmittingPatches
parentdiffcore-pickaxe.c: a void function shouldn't try to return something (diff)
parentt/t3415: use && where applicable. (diff)
downloadtgif-c752e7f3e8d96a9673ad248addc9418164bd3ce6.tar.xz
Merge branch 'maint'
* maint: t/t3415: use && where applicable. SubmittingPatches: Document some extra tags used in commit messages
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches21
1 files changed, 15 insertions, 6 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index ece3c77482..72741ebda1 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -264,12 +264,21 @@ the change to its true author (see (2) above).
Also notice that a real name is used in the Signed-off-by: line. Please
don't hide your real name.
-Some people also put extra tags at the end.
-
-"Acked-by:" says that the patch was reviewed by the person who
-is more familiar with the issues and the area the patch attempts
-to modify. "Tested-by:" says the patch was tested by the person
-and found to have the desired effect.
+If you like, you can put extra tags at the end:
+
+1. "Reported-by:" is used to to credit someone who found the bug that
+ the patch attempts to fix.
+2. "Acked-by:" says that the person who is more familiar with the area
+ the patch attempts to modify liked the patch.
+3. "Reviewed-by:", unlike the other tags, can only be offered by the
+ reviewer and means that she is completely satisfied that the patch
+ is ready for application. It is usually offered only after a
+ detailed review.
+4. "Tested-by:" is used to indicate that the person applied the patch
+ and found it to have the desired effect.
+
+You can also create your own tag or use one that's in common usage
+such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".
------------------------------------------------
An ideal patch flow