summaryrefslogtreecommitdiff
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
authorLibravatar Adam Spiers <git@adamspiers.org>2012-12-16 19:36:00 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2012-12-16 18:30:53 -0800
commita26fd033af23389cd6e17d078007aaec61b5c9c1 (patch)
tree4545f3d761b3ed22adebe2f0193f4c7fa4a77ab3 /Documentation/SubmittingPatches
parentSubmittingPatches: add convention of prefixing commit messages (diff)
downloadtgif-a26fd033af23389cd6e17d078007aaec61b5c9c1.tar.xz
Documentation: move support for old compilers to CodingGuidelines
The "Try to be nice to older C compilers" text is clearly a guideline to be borne in mind whilst coding rather than when submitting patches. Signed-off-by: Adam Spiers <git@adamspiers.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches13
1 files changed, 0 insertions, 13 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c107cb1693..c34c9d12c6 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -127,19 +127,6 @@ in templates/hooks--pre-commit. To help ensure this does not happen,
run git diff --check on your changes before you commit.
-(1a) Try to be nice to older C compilers
-
-We try to support a wide range of C compilers to compile
-git with. That means that you should not use C99 initializers, even
-if a lot of compilers grok it.
-
-Also, variables have to be declared at the beginning of the block
-(you can check this with gcc, using the -Wdeclaration-after-statement
-option).
-
-Another thing: NULL pointers shall be written as NULL, not as 0.
-
-
(2) Generate your patch using git tools out of your commits.
git based diff tools generate unidiff which is the preferred format.