summaryrefslogtreecommitdiff
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
authorLibravatar Ævar Arnfjörð Bjarmason <avarab@gmail.com>2010-07-28 14:11:25 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2010-07-28 13:51:33 -0700
commit43e331e6ee46ba156d43f1fd3ebc91cc35575e47 (patch)
treed3cace6e9cb9602620367f1f0d359556ae99af95 /Documentation/SubmittingPatches
parentSubmittingPatches: Clarify the Signed-off-by rules (diff)
downloadtgif-43e331e6ee46ba156d43f1fd3ebc91cc35575e47.tar.xz
SubmittingPatches: Cite the 50 char subject limit
Change the SubmittingPatches recommendations to mention the 50 character soft limit on patch subject lines. 50 characters is the soft limit mentioned in git-commit(1) and gittutorial(7), it's also the point at which Gitweb, GitHub and various other Git front ends start abbreviating the commit message. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches3
1 files changed, 2 insertions, 1 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 2e18f6b440..ece3c77482 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -7,7 +7,8 @@ Checklist (and a short version for the impatient):
before committing
- do not check in commented out code or unneeded files
- the first line of the commit message should be a short
- description and should skip the full stop
+ description (50 characters is the soft limit, see DISCUSSION
+ in git-commit(1)), and should skip the full stop
- the body should provide a meaningful commit message, which:
- uses the imperative, present tense: "change",
not "changed" or "changes".