diff options
| author |  Fabian Keil <fk@fabiankeil.de> | 2011-01-31 20:29:46 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2011-02-27 02:13:21 -0800 |
| commit | e7cad3ccd05461b0defdef86c9d786ab6fb9fe40 (patch) | |
| tree | e05fcda753436486013ceee064bc402f8c4b8c19 /Documentation/CodingGuidelines | |
| parent | branch_merged: fix grammar in warning (diff) | |
| download | tgif-e7cad3ccd05461b0defdef86c9d786ab6fb9fe40.tar.xz | |
git-cvsimport.perl: Bail out right away when reading from the server fails
If the CVS server is down, this reduced the git-cvsimport output from:
ssh: connect to host ijbswa.cvs.sourceforge.net port 22: Connection refused
Use of uninitialized value $rep in scalar chomp at /usr/local/libexec/git-core/git-cvsimport line 369.
Use of uninitialized value $rep in substitution (s///) at /usr/local/libexec/git-core/git-cvsimport line 370.
Expected Valid-requests from server, but got: <unknown>
to the less noisy:
ssh: connect to host ijbswa.cvs.sourceforge.net port 22: Connection refused
Failed to read from server at /usr/local/libexec/git-core/git-cvsimport line 370.
In this case a silent exit() instead of the die() would probably do,
but I assume that there could be cases where the connection attempt
succeeds, but reading from the server fails for other reasons.
Signed-off-by: Fabian Keil <fk@fabiankeil.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/CodingGuidelines')
0 files changed, 0 insertions, 0 deletions