diff options
| author |  Jonathan Nieder <jrnieder@gmail.com> | 2011-05-27 05:18:33 -0500 |
|---|---|---|
| committer | Jonathan Nieder <jrnieder@gmail.com> | 2011-06-15 02:32:50 -0500 |
| commit | abe27c0cbd97bf6a693004ddb411392ed596a853 (patch) | |
| tree | e1ec602814a171bdb4ea8bfaedf75faaea5aa615 /Documentation/CodingGuidelines | |
| parent | Merge branch 'db/delta-applier' into db/text-delta (diff) | |
| download | tgif-abe27c0cbd97bf6a693004ddb411392ed596a853.tar.xz | |
vcs-svn: guard against overflow when computing preimage length
Signed integer overflow produces undefined behavior in C and off_t is
a signed type. For predictable behavior, add some checks to protect
in advance against overflow.
On 32-bit systems ftell as called by buffer_tmpfile_prepare_to_read
is likely to fail with EOVERFLOW when reading the corresponding
postimage, and this patch does not fix that. So it's more of a
futureproofing measure than a complete fix.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Diffstat (limited to 'Documentation/CodingGuidelines')
0 files changed, 0 insertions, 0 deletions