diff options
| author |  René Scharfe <l.s.r@web.de> | 2019-08-25 15:26:40 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-08-26 11:32:28 -0700 |
| commit | fd99c2dd9b0b24fe4bb36366a6b1ff9e29b29286 (patch) | |
| tree | 7df8117550b21aa78a1abcf7daf89625ebe782e9 | |
| parent | log-tree: always use return value of strbuf_detach() (diff) | |
| download | tgif-fd99c2dd9b0b24fe4bb36366a6b1ff9e29b29286.tar.xz | |
grep: use return value of strbuf_detach()
Append the strbuf buffer only after detaching it. There is no practical
difference here, as the strbuf is not empty and no strbuf_ function is
called between storing the pointer to the still attached buffer and
calling strbuf_detach(), so that pointer is valid, but make sure to
follow the standard sequence anyway for consistency.
Signed-off-by: René Scharfe <l.s.r@web.de>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/grep.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/grep.c b/builtin/grep.c index 2699001fbd..69ac053acc 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -1110,8 +1110,8 @@ int cmd_grep(int argc, const char **argv, const char *prefix) strbuf_addf(&buf, "+/%s%s", strcmp("less", pager) ? "" : "*", opt.pattern_list->pattern); - string_list_append(&path_list, buf.buf); - strbuf_detach(&buf, NULL); + string_list_append(&path_list, + strbuf_detach(&buf, NULL)); } } |