diff options
| author |  Jeff King <peff@peff.net> | 2020-01-16 13:34:23 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-01-16 14:46:28 -0800 |
| commit | fbce03d3291e80b76a75d37a44ecf4ab238e6837 (patch) | |
| tree | 1d28417dfa4c0c3f19309772b2203efbed8ceb1d | |
| parent | msvc: accommodate for vcpkg's upgrade to OpenSSL v1.1.x (diff) | |
| download | tgif-fbce03d3291e80b76a75d37a44ecf4ab238e6837.tar.xz | |
t4018: drop "debugging" cat from hunk-header tests
We run a series of hunk-header tests in a loop, and each one does this:
test_when_finished 'cat actual' && # for debugging only
This is pretty pointless. When the test succeeds, we waste time running
a useless cat process. If you're debugging a failure with "-i", then we
won't run the when-finished part at all. So it helps only if you're
running with something like "--verbose-log".
Since we expect the tests to succeed most of the time, a better way to
do this would be a helper that checks the output and dumps "actual" only
when it fails. But it's probably not even worth the effort, as anyone
debugging a failure could just run with "-i" and investigate the
"actual" file themselves.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t4018-diff-funcname.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh index 6f5ef0035e..803f717a94 100755 --- a/t/t4018-diff-funcname.sh +++ b/t/t4018-diff-funcname.sh @@ -105,7 +105,6 @@ do result=success fi test_expect_$result "hunk header: $i" " - test_when_finished 'cat actual' && # for debugging only git diff -U1 $i >actual && grep '@@ .* @@.*RIGHT' actual " |