diff options
| author |  Todd Zullinger <tmz@pobox.com> | 2009-02-08 18:12:43 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2009-02-09 00:06:36 -0800 |
| commit | f6b98e46bdf64454d7c6ab76d617237118799d7b (patch) | |
| tree | 633b22580dbfff3c8744f30b03276cfb2de55066 | |
| parent | Merge branch 'maint' (diff) | |
| download | tgif-f6b98e46bdf64454d7c6ab76d617237118799d7b.tar.xz | |
git-web--browse: Fix check for /bin/start
The previous check in git-web--browse for /bin/start used test -n
/bin/start, which was always true. This lead to "start" being tried
first in the browser list. On systems with upstart installed, "start"
exists and might be in the PATH, but it makes a poor choice for a web
browser. Instead, test that /bin/start exists and is executable.
Signed-off-by: Todd Zullinger <tmz@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | git-web--browse.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-web--browse.sh b/git-web--browse.sh index 78d236b77f..7ed0faddcd 100755 --- a/git-web--browse.sh +++ b/git-web--browse.sh @@ -115,7 +115,7 @@ if test -z "$browser" ; then browser_candidates="open $browser_candidates" fi # /bin/start indicates MinGW - if test -n /bin/start; then + if test -x /bin/start; then browser_candidates="start $browser_candidates" fi |