diff options
| author |  Jonathan Nieder <jrnieder@gmail.com> | 2011-05-21 14:40:32 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2011-05-21 22:29:33 -0700 |
| commit | f5b7ce1b9041d19658b79d8b956d7e79ec6006bd (patch) | |
| tree | f2c08a7d7ea38f35c6138eb5a413d51f0a7c0329 | |
| parent | userdiff/perl: catch sub with brace on second line (diff) | |
| download | tgif-f5b7ce1b9041d19658b79d8b956d7e79ec6006bd.tar.xz | |
tests: make test_expect_code quieter on success
A command exiting with the expected status is not particularly
notable.
While the indication of progress might be useful when tracking down
where in a test a failure has happened, the same applies to most other
test helpers, which are quiet about success, so this single helper's
output stands out in an unpleasant way. An alternative method for
showing progress information might to invent a --progress option that
runs tests with "set -x", or until that is available, to run tests
using commands like
prove -v -j2 --shuffle --exec='sh -x' t2202-add-addremove.sh
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/test-lib.sh | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/t/test-lib.sh b/t/test-lib.sh index 8a274fbe79..a174f66961 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -731,12 +731,11 @@ test_expect_code () { exit_code=$? if test $exit_code = $want_code then - echo >&2 "test_expect_code: command exited with $exit_code: $*" return 0 - else - echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*" - return 1 fi + + echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*" + return 1 } # test_cmp is a helper function to compare actual and expected output. |