diff options
| author |  Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2018-02-25 19:46:27 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-02-27 14:52:46 -0800 |
| commit | f0e19cb7ced7b640d363b61d7ce17b83901777da (patch) | |
| tree | a7e71f605fd3723bdd07eea04bf791bc96577a03 | |
| parent | Git.pm: remove redundant "use strict" from sub-package (diff) | |
| download | tgif-f0e19cb7ced7b640d363b61d7ce17b83901777da.tar.xz | |
Git.pm: add the "use warnings" pragma
Amend Git.pm to load the "warnings" pragma like the rest of the code
in perl/ in addition to the existing "strict" pragma. This is
considered the bare minimum best practice in Perl.
Ever since this code was introduced in b1edc53d06 ("Introduce
Git.pm (v4)", 2006-06-24) it's only been using "strict", not
"warnings".
This leaves contrib/buildsystems/Generators/{QMake,VCproj}.pm and
contrib/mw-to-git/Git/Mediawiki.pm without "use warnings". Amending
those would be a sensible follow-up change, but I don't have an easy
way to test those so I'm not changing them.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | perl/Git.pm | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/perl/Git.pm b/perl/Git.pm index 99e5d943af..7ec16e6dde 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -9,6 +9,7 @@ package Git; use 5.008; use strict; +use warnings; BEGIN { |