diff options
| author |  Elia Pinto <gitter.spiros@gmail.com> | 2016-01-12 11:49:33 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-01-12 11:49:47 -0800 |
| commit | e74ef604974192712c38f77cd751b00ad36e1378 (patch) | |
| tree | 0a2223ac2bc7ca74151886606a0b7adea1362b07 | |
| parent | t9138-git-svn-authors-prog.sh: use the $( ... ) construct for command substit... (diff) | |
| download | tgif-e74ef604974192712c38f77cd751b00ad36e1378.tar.xz | |
t9145-git-svn-master-branch.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9145-git-svn-master-branch.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t9145-git-svn-master-branch.sh b/t/t9145-git-svn-master-branch.sh index 6559137493..3bbf341f6a 100755 --- a/t/t9145-git-svn-master-branch.sh +++ b/t/t9145-git-svn-master-branch.sh @@ -17,8 +17,8 @@ test_expect_success 'git svn clone --stdlayout sets up trunk as master' ' git svn clone -s "$svnrepo" g && ( cd g && - test x`git rev-parse --verify refs/remotes/origin/trunk^0` = \ - x`git rev-parse --verify refs/heads/master^0` + test x$(git rev-parse --verify refs/remotes/origin/trunk^0) = \ + x$(git rev-parse --verify refs/heads/master^0) ) ' |