summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2015-08-17 15:07:50 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-08-17 15:07:50 -0700
commite69b40828070b71c423820d1e35d5fb1e5b1a550 (patch)
treef6cb843ebe7caa8b57074cf41ab5d4fdcf6270c8
parentSecond batch for 2.6 (diff)
parentpull: allow dirty tree when rebase.autostash enabled (diff)
downloadtgif-e69b40828070b71c423820d1e35d5fb1e5b1a550.tar.xz
Merge branch 'kd/pull-rebase-autostash'
"git pull --rebase" has been taught to pay attention to rebase.autostash configuration. * kd/pull-rebase-autostash: pull: allow dirty tree when rebase.autostash enabled
-rw-r--r--builtin/pull.c6
-rwxr-xr-xt/t5520-pull.sh11
2 files changed, 16 insertions, 1 deletions
diff --git a/builtin/pull.c b/builtin/pull.c
index 722a83c51b..b7bc1fff5e 100644
--- a/builtin/pull.c
+++ b/builtin/pull.c
@@ -823,10 +823,14 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
hashclr(orig_head);
if (opt_rebase) {
+ int autostash = 0;
+
if (is_null_sha1(orig_head) && !is_cache_unborn())
die(_("Updating an unborn branch with changes added to the index."));
- die_on_unclean_work_tree(prefix);
+ git_config_get_bool("rebase.autostash", &autostash);
+ if (!autostash)
+ die_on_unclean_work_tree(prefix);
if (get_rebase_fork_point(rebase_fork_point, repo, *refspecs))
hashclr(rebase_fork_point);
diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
index f4a7193677..a0013ee32f 100755
--- a/t/t5520-pull.sh
+++ b/t/t5520-pull.sh
@@ -245,6 +245,17 @@ test_expect_success '--rebase fails with multiple branches' '
test modified = "$(git show HEAD:file)"
'
+test_expect_success 'pull --rebase succeeds with dirty working directory and rebase.autostash set' '
+ test_config rebase.autostash true &&
+ git reset --hard before-rebase &&
+ echo dirty >new_file &&
+ git add new_file &&
+ git pull --rebase . copy &&
+ test_cmp_rev HEAD^ copy &&
+ test "$(cat new_file)" = dirty &&
+ test "$(cat file)" = "modified again"
+'
+
test_expect_success 'pull.rebase' '
git reset --hard before-rebase &&
test_config pull.rebase true &&