summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Shourya Shukla <shouryashukla.oo@gmail.com>2020-08-25 17:00:18 +0530
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-08-25 13:43:10 -0700
commite0f7ae564eecd5e43704c9640ea68ff93a8f316e (patch)
tree02fb9a690f0934d9debc1f77591e8dfff559c90b
parentsubmodule: port submodule subcommand 'summary' from shell to C (diff)
downloadtgif-e0f7ae564eecd5e43704c9640ea68ff93a8f316e.tar.xz
submodule: eliminate unused parameters from print_submodule_summary()
Eliminate the parameters 'missing_{src,dst}' from the 'print_submodule_summary()' function call since they are not used anywhere in the function. Reported-by: Jeff King <peff@peff.net> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/submodule--helper.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 63ea39025d..b83f840251 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -982,7 +982,6 @@ static char* verify_submodule_committish(const char *sm_path,
static void print_submodule_summary(struct summary_cb *info, char* errmsg,
int total_commits, const char *displaypath,
const char *src_abbrev, const char *dst_abbrev,
- int missing_src, int missing_dst,
struct module_cb *p)
{
if (p->status == 'T') {
@@ -1154,8 +1153,7 @@ static void generate_submodule_summary(struct summary_cb *info,
print_submodule_summary(info, errmsg, total_commits,
displaypath, src_abbrev,
- dst_abbrev, missing_src,
- missing_dst, p);
+ dst_abbrev, p);
free(displaypath);
free(src_abbrev);