diff options
| author |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2018-04-03 18:28:22 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-04-06 08:30:03 +0900 |
| commit | dde154b5bd84e6258b496498901eb24b4914ec6b (patch) | |
| tree | 41a7048cf5d0b31a362cb960dc305479d07543ad | |
| parent | t1300: avoid relying on a bug (diff) | |
| download | tgif-dde154b5bd84e6258b496498901eb24b4914ec6b.tar.xz | |
t1300: remove unreasonable expectation from TODO
In https://public-inbox.org/git/7vvc8alzat.fsf@alter.siamese.dyndns.org/
a reasonable patch was made quite a bit less so by changing a test case
demonstrating a bug to a test case that demonstrates that we ask for too
much: the test case 'unsetting the last key in a section removes header'
now expects a future bug fix to be able to determine whether a free-form
comment above a section header refers to said section or not.
Rather than shooting for the stars (and not even getting off the
ground), let's start shooting for something obtainable and be reasonably
confident that we *can* get it.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t1300-config.sh | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 05c011ee03..3ab83fff8f 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1390,7 +1390,7 @@ test_expect_success 'urlmatch with wildcard' ' ' # good section hygiene -test_expect_failure 'unsetting the last key in a section removes header' ' +test_expect_failure '--unset last key removes section (except if commented)' ' cat >.git/config <<-\EOF && # some generic comment on the configuration file itself # a comment specific to this "section" section. @@ -1404,6 +1404,25 @@ test_expect_failure 'unsetting the last key in a section removes header' ' cat >expect <<-\EOF && # some generic comment on the configuration file itself + # a comment specific to this "section" section. + [section] + # some intervening lines + # that should also be dropped + + # please be careful when you update the above variable + EOF + + git config --unset section.key && + test_cmp expect .git/config && + + cat >.git/config <<-\EOF && + [section] + key = value + [next-section] + EOF + + cat >expect <<-\EOF && + [next-section] EOF git config --unset section.key && |